Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Code Cleanup]: Very Unfinished: Reducing String Data Checks and Code with For Loops and Enums #2615

Draft
wants to merge 6 commits into
base: development
Choose a base branch
from
Draft

[Code Cleanup]: Very Unfinished: Reducing String Data Checks and Code with For Loops and Enums #2615

wants to merge 6 commits into from
+73 −92

Conversation

Sumwatt0
Copy link
Contributor

@Sumwatt0 Sumwatt0 commented Aug 8, 2024 •
edited
Loading

About The Pull Request

  • Cleaned up the code for the selected tab in camp selection.

Why This Is Good For ClanGen

The code is more readable and concise.

Proof of Testing

Screen.Recording.2024-08-08.at.3.54.45.AM.mov

Changelog/Credits

[Code]: Code Cleanups

Credit: (Sumwatt/Sumwatt0)

@Sumwatt0 Sumwatt0 changed the title Code Cleanups Code Cleanup Aug 8, 2024
@Sumwatt0 Sumwatt0 marked this pull request as draft August 8, 2024 21:14
@Sumwatt0
Oops forgot to delete that.
15573a2 
Deleted a line that should've been deleted last commit.
@Sumwatt0 Sumwatt0 changed the title Code Cleanup [Code Cleanup]: This is going to be the most satisfying pull request. Aug 8, 2024
@Sumwatt0 Sumwatt0 changed the title [Code Cleanup]: This is going to be the most satisfying pull request. [Code Cleanup]: This is going to be the most satisfying PR. Aug 8, 2024
@Sumwatt0 Sumwatt0 changed the title [Code Cleanup]: This is going to be the most satisfying PR. [Code Cleanup]: This is going to be the most satisfying PR Aug 8, 2024
@Sumwatt0
Trying something
2806631 
Ill fix the other stuff later but im saving these changes for now.
Just trying to make the BIOME an enum.
@Sumwatt0 Sumwatt0 changed the title [Code Cleanup]: This is going to be the most satisfying PR [Code Cleanup]: Very Unfinished: This is going to be the most satisfying PR Aug 12, 2024
@Sumwatt0 Sumwatt0 changed the title [Code Cleanup]: Very Unfinished: This is going to be the most satisfying PR [Code Cleanup]: Very Unfinished: Satisfying PR Aug 12, 2024
@archanyhm
Copy link
Collaborator

Please adjust the title of the PR to be more precise. "Satisfying PR" is very vague and "Code cleanup" is a bit too generic.

@Sumwatt0 Sumwatt0 changed the title [Code Cleanup]: Very Unfinished: Satisfying PR [Code Cleanup]: Very Unfinished: Reducing String Data Checks and Code with For Loops Aug 16, 2024
@Sumwatt0 Sumwatt0 changed the title [Code Cleanup]: Very Unfinished: Reducing String Data Checks and Code with For Loops [Code Cleanup]: Very Unfinished: Reducing String Data Checks and Code with For Loops and Enums Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Sumwatt0 @archanyhm